Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the LoRA section of the quick tour documentation to correct pluralization/grammar around trigger words for LoRAs.
Changes:
- Fixes “Some LoRA's … trigger it” to “Some LoRAs … trigger them” for correct plural/pronoun agreement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/source/en/quicktour.md
Outdated
| @@ -103,7 +103,7 @@ export_to_video(video, "output.mp4", fps=16) | |||
|
|
|||
| Adapters insert a small number of trainable parameters to the original base model. Only the inserted parameters are fine-tuned while the rest of the model weights remain frozen. This makes it fast and cheap to fine-tune a model on a new style. Among adapters, [LoRA's](./tutorials/using_peft_for_inference) are the most popular. | |||
There was a problem hiding this comment.
Line 104 still uses "LoRA's" as a plural (apostrophe) while line 106 was corrected to "LoRAs". For consistency and correct grammar, update the link text "[LoRA's]" to the plural form (e.g., "[LoRAs]") since this is not possessive here.
Suggested change
| Adapters insert a small number of trainable parameters to the original base model. Only the inserted parameters are fine-tuned while the rest of the model weights remain frozen. This makes it fast and cheap to fine-tune a model on a new style. Among adapters, [LoRA's](./tutorials/using_peft_for_inference) are the most popular. | |
| Adapters insert a small number of trainable parameters to the original base model. Only the inserted parameters are fine-tuned while the rest of the model weights remain frozen. This makes it fast and cheap to fine-tune a model on a new style. Among adapters, [LoRAs](./tutorials/using_peft_for_inference) are the most popular. |
Xyc2016
force-pushed
the
fix-lora-grammar
branch
from
4a66ac4 to
a67e929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoRA's→LoRAsin two places (lines 104 and 106) - plural, not possessivetrigger it→trigger them(pronoun agreement: "Some LoRAs" is plural)Changes
Line 104:
Line 106:
Location
docs/source/en/quicktour.md, lines 104 and 106